fix(lint): resolver type narrowing, NoneType en auth y optimizar sync masivo de moodle en memoria

This commit is contained in:
2026-10-16 16:06:21 -03:00
parent fe5acb6119
commit cf368036a6
5 changed files with 46 additions and 34 deletions
+3 -2
View File
@@ -42,8 +42,9 @@ class AuditService:
# 2. Determinar IP de origen
if not ip_address and has_request_context():
if request.headers.get('X-Forwarded-For'):
ip_address = request.headers.get('X-Forwarded-For').split(',')[0].strip()
xfwd = request.headers.get('X-Forwarded-For')
if xfwd:
ip_address = xfwd.split(',')[0].strip()
else:
ip_address = request.remote_addr
+11 -6
View File
@@ -294,6 +294,11 @@ class MoodleClient:
})
users_list = moodle_users.get('users', []) if isinstance(moodle_users, dict) else []
# Cargar todos los usuarios existentes en memoria indexados por email y DNI (O(1) lookup)
all_existing_users = User.query.all()
user_by_email = {u.email.lower(): u for u in all_existing_users if u.email}
user_by_dni = {str(u.document_number): u for u in all_existing_users if u.document_number}
created_count = 0
updated_count = 0
@@ -317,17 +322,14 @@ class MoodleClient:
else:
target_role = role_alumno
# Buscar usuario existente por email o DNI
user = None
if email:
user = User.query.filter(User.email.ilike(email)).first()
if not user and dni:
user = User.query.filter(User.document_number == dni).first()
# Buscar usuario existente en memoria por email o DNI
user = user_by_email.get(email) or (user_by_dni.get(dni) if dni else None)
if user:
changed = False
if dni and not user.document_number:
user.document_number = dni
user_by_dni[dni] = user
changed = True
if firstname and not user.first_name:
user.first_name = firstname
@@ -356,6 +358,9 @@ class MoodleClient:
)
new_user.set_password(dni or username)
db.session.add(new_user)
user_by_email[email] = new_user
if dni:
user_by_dni[dni] = new_user
created_count += 1
db.session.commit()