fix(typing): resolucion integral de advertencias de tipado, extraccion de payload con get_request_payload y limpieza de modelos
This commit is contained in:
+15
-85
@@ -16,7 +16,7 @@ from app.models.user import User
|
||||
from app.models.enrollment import StudentEnrollment
|
||||
from app.services.enrollment_service import EnrollmentService
|
||||
from app.services.gradebook_service import GradebookService
|
||||
from dependencies import get_current_user, require_roles
|
||||
from dependencies import get_request_payload, get_current_user, require_roles
|
||||
|
||||
academic_router = APIRouter(prefix="/api/v1", tags=["Academic Management"])
|
||||
|
||||
@@ -54,12 +54,7 @@ async def create_career(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Crea una nueva carrera en la institución."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
name = (data.get('name') or '').strip()
|
||||
code = (data.get('code') or '').strip()
|
||||
@@ -89,12 +84,7 @@ async def update_career(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Actualiza una carrera existente."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
career = Career.query.get(id)
|
||||
if not career:
|
||||
@@ -206,12 +196,7 @@ async def create_subject(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Crea una nueva asignatura y la vincula a una o varias carreras."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
code = (data.get('code') or '').strip().upper()
|
||||
name = (data.get('name') or '').strip()
|
||||
@@ -279,12 +264,7 @@ async def update_subject(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Actualiza una asignatura existente."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
subject = Subject.query.get(id)
|
||||
if not subject:
|
||||
@@ -437,12 +417,7 @@ async def create_commission(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Crea una comisión vinculada a una asignatura, ciclo lectivo y docente(s)."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
subject_id = data.get('subject_id')
|
||||
code = (data.get('code') or '').strip()
|
||||
@@ -575,12 +550,7 @@ async def update_commission(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Actualiza los datos de una comisión."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
comm = Commission.query.get(id)
|
||||
if not comm:
|
||||
@@ -716,12 +686,7 @@ async def create_academic_term(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Crea un nuevo ciclo lectivo en el sistema."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
code = (data.get('code') or '').strip().upper()
|
||||
name = (data.get('name') or '').strip()
|
||||
@@ -838,12 +803,7 @@ async def assign_commission_teacher(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Asigna el docente titular a una comisión."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
comm = Commission.query.get(id)
|
||||
if not comm:
|
||||
@@ -883,12 +843,7 @@ async def add_commission_teacher(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Agrega un docente (titular o adjunto/co-docente) a una comisión."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
user_id = data.get('user_id') or data.get('teacher_id')
|
||||
if not user_id:
|
||||
@@ -994,12 +949,7 @@ async def enroll_commission_student(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Matricula a un estudiante en una comisión."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
student_id = data.get('student_id')
|
||||
notes = data.get('notes')
|
||||
@@ -1050,12 +1000,7 @@ async def update_commission_enrollment(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Actualiza el estado de matrícula de un estudiante."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
status_val = data.get('status', 'activo')
|
||||
notes = data.get('notes')
|
||||
@@ -1102,12 +1047,7 @@ async def save_commission_grades(
|
||||
current_user: User = Depends(get_current_user)
|
||||
):
|
||||
"""Carga de notas individual o masiva para hitos evaluativos."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
try:
|
||||
if 'grades' in data and isinstance(data['grades'], list):
|
||||
@@ -1212,12 +1152,7 @@ async def create_milestone_type(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Crea una nueva tipificación de hito evaluativo."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
name = str(data.get('name', '')).strip()
|
||||
code = str(data.get('code', '')).strip().lower().replace(' ', '_')
|
||||
@@ -1263,12 +1198,7 @@ async def update_milestone_type(
|
||||
current_user: User = Depends(require_roles(["ADMIN", "BEDELIA"]))
|
||||
):
|
||||
"""Actualiza una tipificación de hito evaluativo existente."""
|
||||
data = {}
|
||||
try:
|
||||
data = await request.json()
|
||||
except Exception:
|
||||
form = await request.form()
|
||||
data = dict(form)
|
||||
data = await get_request_payload(request)
|
||||
|
||||
mt = MilestoneType.query.get(id)
|
||||
if not mt:
|
||||
|
||||
Reference in New Issue
Block a user