feat: harden student grade privacy, eradicate mock hallucinations, and normalize profile tool access (v3.8.33)
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "frontend",
|
||||
"version": "3.8.32",
|
||||
"version": "3.8.33",
|
||||
"description": "",
|
||||
"main": "index.js",
|
||||
"scripts": {
|
||||
|
||||
+3
-3
@@ -86,9 +86,9 @@ const env = nunjucks.configure(path.join(__dirname, '../views'), {
|
||||
});
|
||||
|
||||
// Versiones institucionales del sistema
|
||||
const APP_VERSION = '3.8.32';
|
||||
const FRONTEND_VERSION = '3.8.32';
|
||||
const BACKEND_VERSION = '3.8.32';
|
||||
const APP_VERSION = '3.8.33';
|
||||
const FRONTEND_VERSION = '3.8.33';
|
||||
const BACKEND_VERSION = '3.8.33';
|
||||
|
||||
env.addGlobal('app_version', APP_VERSION);
|
||||
env.addGlobal('frontend_version', FRONTEND_VERSION);
|
||||
|
||||
@@ -4,12 +4,20 @@ const { requireAuth } = require('../middlewares/authMiddleware');
|
||||
|
||||
router.use(requireAuth);
|
||||
|
||||
const getNormalizedRole = (user) => {
|
||||
const roleStr = (user?.role || '').toLowerCase();
|
||||
if (roleStr.includes('admin')) return 'admin';
|
||||
if (roleStr.includes('bedel')) return 'bedelia';
|
||||
if (roleStr.includes('docent') || roleStr.includes('prof')) return 'docente';
|
||||
return 'alumno';
|
||||
};
|
||||
|
||||
const handleMySubjectsList = async (req, res) => {
|
||||
try {
|
||||
let commissions = [];
|
||||
const roleStr = (req.user?.role || '').toLowerCase();
|
||||
const isDocente = roleStr.includes('docent') || roleStr.includes('prof');
|
||||
const isAlumno = roleStr.includes('alum') || roleStr.includes('estud');
|
||||
const role = getNormalizedRole(req.user);
|
||||
const isDocente = role === 'docente';
|
||||
const isAlumno = role === 'alumno';
|
||||
|
||||
const params = {};
|
||||
if (isDocente) {
|
||||
@@ -41,7 +49,7 @@ const handleMySubjectsList = async (req, res) => {
|
||||
title: 'Mis Materias — Edu-Space',
|
||||
commissions,
|
||||
view_mode: 'all',
|
||||
role: req.user?.role || 'admin'
|
||||
role
|
||||
});
|
||||
} catch (err) {
|
||||
console.error('Error in my_subjects list:', err.message);
|
||||
@@ -49,7 +57,7 @@ const handleMySubjectsList = async (req, res) => {
|
||||
title: 'Mis Materias',
|
||||
commissions: [],
|
||||
view_mode: 'all',
|
||||
role: req.user?.role || 'admin'
|
||||
role: getNormalizedRole(req.user)
|
||||
});
|
||||
}
|
||||
};
|
||||
@@ -67,18 +75,23 @@ const handleMySubjectDetail = async (req, res) => {
|
||||
try {
|
||||
let commission = null;
|
||||
let enrollments = [];
|
||||
const role = getNormalizedRole(req.user);
|
||||
const isAlumno = role === 'alumno';
|
||||
|
||||
try {
|
||||
const [cResp, enrResp] = await Promise.allSettled([
|
||||
req.apiClient.get(`/commissions/${id}`),
|
||||
req.apiClient.get(`/commissions/${id}/enrollments`)
|
||||
]);
|
||||
|
||||
if (cResp.status === 'fulfilled' && cResp.value.data?.commission) {
|
||||
commission = cResp.value.data.commission;
|
||||
// Protección de Privacidad: Un alumno jamás debe consultar la lista de inscriptos ni notas de sus compañeros
|
||||
const requests = [req.apiClient.get(`/commissions/${id}`)];
|
||||
if (!isAlumno) {
|
||||
requests.push(req.apiClient.get(`/commissions/${id}/enrollments`));
|
||||
}
|
||||
if (enrResp.status === 'fulfilled' && enrResp.value.data?.enrollments) {
|
||||
enrollments = enrResp.value.data.enrollments;
|
||||
|
||||
const results = await Promise.allSettled(requests);
|
||||
|
||||
if (results[0].status === 'fulfilled' && results[0].value.data?.commission) {
|
||||
commission = results[0].value.data.commission;
|
||||
}
|
||||
if (!isAlumno && results[1] && results[1].status === 'fulfilled' && results[1].value.data?.enrollments) {
|
||||
enrollments = results[1].value.data.enrollments;
|
||||
}
|
||||
} catch (e) {
|
||||
console.warn('Commission detail API notice:', e.message);
|
||||
@@ -103,7 +116,7 @@ const handleMySubjectDetail = async (req, res) => {
|
||||
enrollments,
|
||||
classroom: null,
|
||||
recent_reservation: null,
|
||||
role: req.user?.role || 'admin'
|
||||
role
|
||||
});
|
||||
} catch (err) {
|
||||
console.error('Error in my_subjects detail:', err.message);
|
||||
@@ -113,7 +126,13 @@ const handleMySubjectDetail = async (req, res) => {
|
||||
|
||||
router.get(['/', '/list', '/my_subjects_list'], handleMySubjectsList);
|
||||
router.get(['/detail', '/commission_detail', '/:id', '/detail/:id'], handleMySubjectDetail);
|
||||
router.get(['/gradebook/:id', '/:id/gradebook'], (req, res) => res.redirect(`/schedule/gradebook/${req.params.id}`));
|
||||
router.get(['/gradebook/:id', '/:id/gradebook'], (req, res) => {
|
||||
const role = getNormalizedRole(req.user);
|
||||
if (role === 'alumno') {
|
||||
return res.redirect('/schedule/my_grades');
|
||||
}
|
||||
return res.redirect(`/schedule/gradebook/${req.params.id}`);
|
||||
});
|
||||
router.get(['/grades', '/my_grades', '/mis-notas'], (req, res) => res.redirect('/schedule/my_grades'));
|
||||
|
||||
module.exports = router;
|
||||
|
||||
@@ -1024,8 +1024,13 @@ router.post(['/delete_reservation', '/delete_reservation/:id', '/reservation/:id
|
||||
|
||||
// 9. Libro de Calificaciones / Gradebook (Fase 3)
|
||||
const handleGradebook = async (req, res) => {
|
||||
let rawId = req.params.id || req.query.id;
|
||||
const roleStr = (req.user?.role || '').toLowerCase();
|
||||
// Protección de Privacidad: los alumnos no pueden acceder a la sábana general de notas
|
||||
if (roleStr.includes('alumn') || roleStr.includes('estudiant')) {
|
||||
return res.redirect('/schedule/my_grades');
|
||||
}
|
||||
|
||||
let rawId = req.params.id || req.query.id;
|
||||
const isDocente = roleStr.includes('docent') || roleStr.includes('prof');
|
||||
|
||||
// Si no se pasó un ID explícito, resolver la primera comisión asignada
|
||||
|
||||
@@ -1162,8 +1162,17 @@
|
||||
</div>
|
||||
|
||||
<div class="sidebar-body flex-grow-1 overflow-y-auto p-2">
|
||||
<ul class="sidebar-nav" id="sidebarNav">
|
||||
{% set user_role = role if role else (auth_user.role if auth_user else 'admin') %}
|
||||
{% set active_nav_user = impersonated_user if (is_impersonating and impersonated_user) else (auth_user if (auth_user and auth_user.is_authenticated) else (current_user if (current_user and current_user.is_authenticated) else user)) %}
|
||||
{% set raw_user_role = ((active_nav_user.role if active_nav_user and active_nav_user.role else (role if role else 'alumno')) | string | lower) %}
|
||||
{% if 'admin' in raw_user_role %}
|
||||
{% set user_role = 'admin' %}
|
||||
{% elif 'bedel' in raw_user_role %}
|
||||
{% set user_role = 'bedelia' %}
|
||||
{% elif 'docent' in raw_user_role or 'prof' in raw_user_role %}
|
||||
{% set user_role = 'docente' %}
|
||||
{% else %}
|
||||
{% set user_role = 'alumno' %}
|
||||
{% endif %}
|
||||
{% if user_role == 'admin' %}
|
||||
<!-- ADMINISTRADOR -->
|
||||
<li class="nav-item">
|
||||
|
||||
@@ -128,6 +128,13 @@
|
||||
<i class="bi bi-journal-check me-1"></i>Libro de Calificaciones (Actas)
|
||||
</a>
|
||||
</div>
|
||||
{% elif role == 'alumno' %}
|
||||
<div class="mt-3">
|
||||
<a href="/schedule/my_grades"
|
||||
class="btn btn-primary btn-sm w-100 shadow-sm" id="view-my-grades-btn">
|
||||
<i class="bi bi-award me-1"></i>Ver mis calificaciones e hitos
|
||||
</a>
|
||||
</div>
|
||||
{% endif %}
|
||||
|
||||
{% if role in ['admin', 'bedelia'] %}
|
||||
@@ -260,6 +267,18 @@
|
||||
<p class="text-muted small">{{ commission.subject.description }}</p>
|
||||
</div>
|
||||
{% endif %}
|
||||
|
||||
<div class="mt-4 pt-3 border-top d-flex flex-wrap gap-2">
|
||||
<a href="/schedule/my_grades" class="btn btn-primary btn-sm">
|
||||
<i class="bi bi-award me-1"></i>Mis Calificaciones e Hitos
|
||||
</a>
|
||||
<a href="/schedule/today_schedule" class="btn btn-outline-secondary btn-sm">
|
||||
<i class="bi bi-calendar-day me-1"></i>Clases de Hoy
|
||||
</a>
|
||||
<a href="/schedule/calendar_view" class="btn btn-outline-secondary btn-sm">
|
||||
<i class="bi bi-calendar3 me-1"></i>Cronograma Semanal
|
||||
</a>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
{% endif %}
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
{% set active_auth_user = auth_user if (auth_user and auth_user.is_authenticated) else (current_user if (current_user and current_user.is_authenticated) else user) %}
|
||||
{% set active_auth_user = impersonated_user if (is_impersonating and impersonated_user) else (auth_user if (auth_user and auth_user.is_authenticated) else (current_user if (current_user and current_user.is_authenticated) else user)) %}
|
||||
{% set current_user_id = active_auth_user.id if active_auth_user and active_auth_user.id else '' %}
|
||||
{% set current_user_email = active_auth_user.email if active_auth_user and active_auth_user.email else '' %}
|
||||
{% set current_user_name = active_auth_user.first_name if (active_auth_user and active_auth_user.first_name) else (active_auth_user.name if active_auth_user else '') %}
|
||||
|
||||
Reference in New Issue
Block a user