feat: harden student grade privacy, eradicate mock hallucinations, and normalize profile tool access (v3.8.33)

This commit is contained in:
2026-10-27 16:55:12 -03:00
parent c59ff1897f
commit f7a549ff1f
15 changed files with 147 additions and 50 deletions
+3 -3
View File
@@ -86,9 +86,9 @@ const env = nunjucks.configure(path.join(__dirname, '../views'), {
});
// Versiones institucionales del sistema
const APP_VERSION = '3.8.32';
const FRONTEND_VERSION = '3.8.32';
const BACKEND_VERSION = '3.8.32';
const APP_VERSION = '3.8.33';
const FRONTEND_VERSION = '3.8.33';
const BACKEND_VERSION = '3.8.33';
env.addGlobal('app_version', APP_VERSION);
env.addGlobal('frontend_version', FRONTEND_VERSION);
+35 -16
View File
@@ -4,12 +4,20 @@ const { requireAuth } = require('../middlewares/authMiddleware');
router.use(requireAuth);
const getNormalizedRole = (user) => {
const roleStr = (user?.role || '').toLowerCase();
if (roleStr.includes('admin')) return 'admin';
if (roleStr.includes('bedel')) return 'bedelia';
if (roleStr.includes('docent') || roleStr.includes('prof')) return 'docente';
return 'alumno';
};
const handleMySubjectsList = async (req, res) => {
try {
let commissions = [];
const roleStr = (req.user?.role || '').toLowerCase();
const isDocente = roleStr.includes('docent') || roleStr.includes('prof');
const isAlumno = roleStr.includes('alum') || roleStr.includes('estud');
const role = getNormalizedRole(req.user);
const isDocente = role === 'docente';
const isAlumno = role === 'alumno';
const params = {};
if (isDocente) {
@@ -41,7 +49,7 @@ const handleMySubjectsList = async (req, res) => {
title: 'Mis Materias — Edu-Space',
commissions,
view_mode: 'all',
role: req.user?.role || 'admin'
role
});
} catch (err) {
console.error('Error in my_subjects list:', err.message);
@@ -49,7 +57,7 @@ const handleMySubjectsList = async (req, res) => {
title: 'Mis Materias',
commissions: [],
view_mode: 'all',
role: req.user?.role || 'admin'
role: getNormalizedRole(req.user)
});
}
};
@@ -67,18 +75,23 @@ const handleMySubjectDetail = async (req, res) => {
try {
let commission = null;
let enrollments = [];
const role = getNormalizedRole(req.user);
const isAlumno = role === 'alumno';
try {
const [cResp, enrResp] = await Promise.allSettled([
req.apiClient.get(`/commissions/${id}`),
req.apiClient.get(`/commissions/${id}/enrollments`)
]);
if (cResp.status === 'fulfilled' && cResp.value.data?.commission) {
commission = cResp.value.data.commission;
// Protección de Privacidad: Un alumno jamás debe consultar la lista de inscriptos ni notas de sus compañeros
const requests = [req.apiClient.get(`/commissions/${id}`)];
if (!isAlumno) {
requests.push(req.apiClient.get(`/commissions/${id}/enrollments`));
}
if (enrResp.status === 'fulfilled' && enrResp.value.data?.enrollments) {
enrollments = enrResp.value.data.enrollments;
const results = await Promise.allSettled(requests);
if (results[0].status === 'fulfilled' && results[0].value.data?.commission) {
commission = results[0].value.data.commission;
}
if (!isAlumno && results[1] && results[1].status === 'fulfilled' && results[1].value.data?.enrollments) {
enrollments = results[1].value.data.enrollments;
}
} catch (e) {
console.warn('Commission detail API notice:', e.message);
@@ -103,7 +116,7 @@ const handleMySubjectDetail = async (req, res) => {
enrollments,
classroom: null,
recent_reservation: null,
role: req.user?.role || 'admin'
role
});
} catch (err) {
console.error('Error in my_subjects detail:', err.message);
@@ -113,7 +126,13 @@ const handleMySubjectDetail = async (req, res) => {
router.get(['/', '/list', '/my_subjects_list'], handleMySubjectsList);
router.get(['/detail', '/commission_detail', '/:id', '/detail/:id'], handleMySubjectDetail);
router.get(['/gradebook/:id', '/:id/gradebook'], (req, res) => res.redirect(`/schedule/gradebook/${req.params.id}`));
router.get(['/gradebook/:id', '/:id/gradebook'], (req, res) => {
const role = getNormalizedRole(req.user);
if (role === 'alumno') {
return res.redirect('/schedule/my_grades');
}
return res.redirect(`/schedule/gradebook/${req.params.id}`);
});
router.get(['/grades', '/my_grades', '/mis-notas'], (req, res) => res.redirect('/schedule/my_grades'));
module.exports = router;
+6 -1
View File
@@ -1024,8 +1024,13 @@ router.post(['/delete_reservation', '/delete_reservation/:id', '/reservation/:id
// 9. Libro de Calificaciones / Gradebook (Fase 3)
const handleGradebook = async (req, res) => {
let rawId = req.params.id || req.query.id;
const roleStr = (req.user?.role || '').toLowerCase();
// Protección de Privacidad: los alumnos no pueden acceder a la sábana general de notas
if (roleStr.includes('alumn') || roleStr.includes('estudiant')) {
return res.redirect('/schedule/my_grades');
}
let rawId = req.params.id || req.query.id;
const isDocente = roleStr.includes('docent') || roleStr.includes('prof');
// Si no se pasó un ID explícito, resolver la primera comisión asignada