""" Test suite for Server-Side Pagination and DB Optimizations. Validates pagination contracts, SQL filtering, and lightweight teacher projection. """ import pytest from fastapi.testclient import TestClient from main import app from app.models.user import User from app.models.role import Role from app.models.subject import Subject, Commission from app.models.career import Career from app.models.audit_log import AuditLog from app.services.audit_service import AuditService from app.services.jwt_service import JWTService from werkzeug.security import generate_password_hash @pytest.fixture def test_admin_headers(init_database): admin = User.query.filter_by(email="admin_pag_test@unicaba.edu.ar").first() if not admin: admin = User( name="Admin Paginacion", email="admin_pag_test@unicaba.edu.ar", password_hash=generate_password_hash("EduSpace2026!"), role="ADMIN", is_active=True ) init_database.session.add(admin) init_database.session.commit() tokens = JWTService.generate_tokens(admin) return {"Authorization": f"Bearer {tokens['access_token']}"} def test_users_pagination_defaults(test_admin_headers, init_database): client = TestClient(app) # Crear varios usuarios si no existen for i in range(1, 30): email = f"pag_user_{i}@unicaba.edu.ar" if not User.query.filter_by(email=email).first(): u = User( name=f"Usuario Paginado {i}", email=email, password_hash=generate_password_hash("pass"), role="ALUMNO", is_active=True ) init_database.session.add(u) init_database.session.commit() # 1. Paginación por defecto (page=1, per_page=25) res = client.get("/api/v1/users", headers=test_admin_headers) assert res.status_code == 200 data = res.json() assert data["status"] == "success" assert "total" in data assert data["page"] == 1 assert data["per_page"] == 25 assert "pages" in data assert len(data["users"]) <= 25 assert data["pages"] >= 2 assert data["has_next"] is True assert data["has_prev"] is False # 2. Segunda página res2 = client.get("/api/v1/users?page=2&per_page=10", headers=test_admin_headers) assert res2.status_code == 200 data2 = res2.json() assert data2["page"] == 2 assert data2["per_page"] == 10 assert len(data2["users"]) == 10 assert data2["has_prev"] is True def test_users_teachers_endpoint(test_admin_headers, init_database): client = TestClient(app) # Crear docente específico teacher = User.query.filter_by(email="profesor_pag_test@unicaba.edu.ar").first() if not teacher: teacher = User( name="Profesor Paginado", email="profesor_pag_test@unicaba.edu.ar", password_hash=generate_password_hash("pass"), role="DOCENTE", is_active=True ) init_database.session.add(teacher) init_database.session.commit() res = client.get("/api/v1/users/teachers", headers=test_admin_headers) assert res.status_code == 200 data = res.json() assert data["status"] == "success" assert "teachers" in data assert any(t["email"] == "profesor_pag_test@unicaba.edu.ar" for t in data["teachers"]) # Verificar que sólo expone campos seguros first = data["teachers"][0] assert "id" in first assert "name" in first assert "email" in first assert "password_hash" not in first def test_audit_logs_pagination_and_search(test_admin_headers, init_database): client = TestClient(app) # Generar eventos de auditoría AuditService.log("LOGIN", "auth", details="Prueba de paginacion audit 1", user_email="admin_pag_test@unicaba.edu.ar") AuditService.log("CREATE", "classrooms", details="Prueba de paginacion audit 2", user_email="admin_pag_test@unicaba.edu.ar") AuditService.log("UPDATE", "academic", details="Materia actualizada para test", user_email="admin_pag_test@unicaba.edu.ar") res = client.get("/api/v1/audit-logs?page=1&per_page=2", headers=test_admin_headers) assert res.status_code == 200 data = res.json() assert data["status"] == "success" assert "pagination" in data pag = data["pagination"] assert pag["page"] == 1 assert pag["per_page"] == 2 assert pag["total"] >= 3 assert pag["pages"] >= 2 assert len(data["logs"]) == 2 # Búsqueda por texto en SQL res_search = client.get("/api/v1/audit-logs?search=Materia+actualizada", headers=test_admin_headers) assert res_search.status_code == 200 data_search = res_search.json() assert len(data_search["logs"]) >= 1 assert any("actualizada" in (l.get("details") or "") for l in data_search["logs"]) def test_subjects_pagination(test_admin_headers, init_database): client = TestClient(app) # Crear carrera y asignaturas car = Career.query.filter_by(code="CAR-PAG").first() if not car: car = Career(name="Carrera Paginacion", code="CAR-PAG") init_database.session.add(car) init_database.session.commit() for i in range(1, 6): code = f"SUBJ-PAG-{i}" if not Subject.query.filter_by(code=code).first(): s = Subject(name=f"Asignatura Paginada {i}", code=code, career_id=car.id, is_active=True) init_database.session.add(s) init_database.session.commit() res = client.get("/api/v1/subjects?page=1&per_page=3", headers=test_admin_headers) assert res.status_code == 200 data = res.json() assert data["status"] == "success" assert data["page"] == 1 assert data["per_page"] == 3 assert len(data["subjects"]) == 3 assert data["total"] >= 5 assert data["has_next"] is True def test_commissions_pagination(test_admin_headers, init_database): client = TestClient(app) # Crear comisiones subj = Subject.query.filter_by(code="SUBJ-PAG-1").first() if subj: for i in range(1, 4): code = f"COMM-PAG-{i}" if not Commission.query.filter_by(code=code, subject_id=subj.id).first(): c = Commission(code=code, subject_id=subj.id, shift="Mañana", active=True) init_database.session.add(c) init_database.session.commit() res = client.get("/api/v1/commissions?page=1&per_page=2", headers=test_admin_headers) assert res.status_code == 200 data = res.json() assert data["status"] == "success" assert data["page"] == 1 assert data["per_page"] == 2 assert len(data["commissions"]) <= 2 assert "total" in data def test_empty_query_params_resilience(test_admin_headers, init_database): """Verifica que query parameters vacíos no causen error 422 Unprocessable Entity.""" client = TestClient(app) res_subj = client.get("/api/v1/subjects?career_id=&active=&search=", headers=test_admin_headers) assert res_subj.status_code == 200 assert "subjects" in res_subj.json() res_comm = client.get("/api/v1/commissions?subject_id=&career_id=&shift=&active=&search=", headers=test_admin_headers) assert res_comm.status_code == 200 assert "commissions" in res_comm.json() res_resv = client.get("/api/v1/reservations?classroom_id=&floor=&shift=&search=&hide_virtual=false", headers=test_admin_headers) assert res_resv.status_code == 200 assert "reservations" in res_resv.json()